fix(snmp): Enhance API output

Enhanced the /api/plugins/cmdb/snmp/ endpoint to include detailed information for devices and communities, not just the primary key (pk).

netbox_cmdb/netbox_cmdb/api/snmp/serializers.py

@@ -3,6 +3,7 @@
 from rest_framework.serializers import ModelSerializer
 
 from netbox_cmdb.models.snmp import SNMP, SNMPCommunity
+from netbox_cmdb.api.common_serializers import CommonDeviceSerializer
 
 
 class SNMPCommunitySerializer(ModelSerializer):
@@ -12,8 +13,27 @@ class Meta:
         fields = "__all__"
 
 
+class SNMPCommunityReadSerializer(ModelSerializer):
+
+    class Meta:
+        model = SNMPCommunity
+        fields = ["community", "type"]
+
+
+class SNMPReadSerializer(ModelSerializer):
+
+    device = CommonDeviceSerializer()
+    community_list = SNMPCommunityReadSerializer(many=True)
+
+    class Meta:
+        model = SNMP
+        fields = "__all__"
+
+
 class SNMPSerializer(ModelSerializer):
 
+    device = CommonDeviceSerializer()
+
     class Meta:
         model = SNMP
         fields = "__all__"

netbox_cmdb/netbox_cmdb/api/snmp/views.py

@@ -4,7 +4,12 @@
 
 from netbox_cmdb.api.viewsets import CustomNetBoxModelViewSet
 from netbox_cmdb.models.snmp import SNMP, SNMPCommunity
-from netbox_cmdb.api.snmp.serializers import SNMPCommunitySerializer, SNMPSerializer
+from netbox_cmdb.api.snmp.serializers import (
+    SNMPCommunitySerializer,
+    SNMPReadSerializer,
+    SNMPSerializer,
+)
+from rest_framework.response import Response
 
 
 class SNMPCommunityViewSet(CustomNetBoxModelViewSet):
@@ -26,3 +31,8 @@ class SNMPViewSet(CustomNetBoxModelViewSet):
         "device__id",
         "device__name",
     ] + filtersets.device_location_filterset
+
+    def list(self, request):
+        queryset = SNMP.objects.all()
+        serializer = SNMPReadSerializer(queryset, many=True)
+        return Response(serializer.data)

netbox_cmdb/netbox_cmdb/tests/snmp/test_snmp_serializer.py

@@ -15,10 +15,11 @@ def test_create(self):
 
         assert community1.community == "my_community"
         assert community1.type == SNMPCommunityType.RO
+        community1.save()
 
         data = {
             "device": self.device1.pk,
-            "community_list": [community1.pk],
+            "community_list": [{"id": community1.pk}],
             "location": "my_location",
             "contact": "my_team",
         }