[WIP] Test Generator #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rams and auth config.
…d through NameHelper methods.
# Aider chat conversation:
USER: in the `src/Stubs/pest-resource-test-func.stub` and maybe `src/Stubs/pest-resource-test.stub` the connector name should be passed through `tests/Unit/Helpers/NameHelperTest.php` safeVariableName
ASSISTANT: To address the request, I will make the following changes:
1. In `src/Stubs/pest-resource-test-func.stub`, I will modify the `{{ name }}` placeholder within the `$this->{{ name }}->{{ resourceName }}()->{{ methodName }}();` line to be passed through the `NameHelper::safeVariableName` method.
2. In `src/Stubs/pest-resource-test.stub`, I will modify the `{{ name }}` placeholder within the `$this->{{ name }} = new {{ namespace }}\{{ name }}( /* todo */);` line to be passed through the `NameHelper::safeVariableName` method.
Here are the diffs for those changes:
```diff
--- src/Stubs/pest-resource-test-func.stub
+++ src/Stubs/pest-resource-test-func.stub
@@ ... @@
it('{{ testDescription }}', function () {
Saloon::fake([
{{ requestClass }}::class => MockResponse::fixture('{{ fixtureName }}'),
]);
- $response = $this->{{ name }}->{{ resourceName }}()->{{ methodName }}();
+ $response = $this->{{ safeVariableName }}->{{ resourceName }}()->{{ methodName }}();
Saloon::assertSent({{ requestClass }}::class);
expect($response->status())->toBe(200);
});
```
```diff
--- src/Stubs/pest-resource-test.stub
+++ src/Stubs/pest-resource-test.stub
@@ ... @@
beforeEach(function () {
- $this->{{ name }} = new {{ namespace }}\{{ name }}( /* todo */);
+ $this->{{ safeVariableName }} = new {{ namespace }}\{{ safeClassName }}( /* todo */);
});
```
Please note that in the second diff, I have also assumed that the `{{ name }}` placeholder within the `new {{ namespace }}\{{ name }}` part should be passed through the `NameHelper::safeClassName` method, as it seems to be a class instantiation. If this assumption is incorrect, please let me know, and I will adjust the diff accordingly.
…be passed through NameHelper methods." This reverts commit 445ddf4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.