Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker-compose.yml #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update docker-compose.yml #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1800588
Update docker-compose.yml
thexavier666 May 11, 2021
9da32ff
Merge branch 'crazy-max:master' into master
thexavier666 Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/pihole/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ services:
ipv4_address: 172.20.0.2
dns:
- 127.0.0.1
- 1.1.1.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this line I see the following errors when pihole container starts:

...
pihole         |   Checking if custom gravity.db is set in /etc/pihole/pihole-FTL.conf
pihole         |   Skipping Gravity Database Update.
pihole         | 
pihole         | s6-rc: info: service legacy-services successfully started
pihole         | fatal: unable to access 'https://github.com/pi-hole/pi-hole/': Could not resolve host: github.com
pihole         | fatal: unable to access 'https://github.com/pi-hole/AdminLTE/': Could not resolve host: github.com
pihole         | fatal: unable to access 'https://github.com/pi-hole/FTL/': Could not resolve host: github.com
pihole         |   Pi-hole version is v5.15.3 (Latest: null)
pihole         |   AdminLTE version is v5.18.3 (Latest: null)
pihole         |   FTL version is v5.20.1 (Latest: null)
pihole         |   Container tag is: 2023.01.10

Then if I docker exec into the pihole container a ping command fails to resolve the name:

$ docker exec -it pihole bash
root@pihole:/# ping google.com
ping: google.com: Temporary failure in name resolution

Adding back that 1.1.1.1 dns entry the startup looks good:

...
pihole         | s6-rc: info: service legacy-services: starting
pihole         |   Checking if custom gravity.db is set in /etc/pihole/pihole-FTL.conf
pihole         |   Skipping Gravity Database Update.
pihole         | 
pihole         | s6-rc: info: service legacy-services successfully started
pihole         |   Pi-hole version is v5.15.3 (Latest: null)
pihole         |   AdminLTE version is v5.18.3 (Latest: null)
pihole         |   FTL version is v5.20.1 (Latest: null)
pihole         |   Container tag is: 2023.01.10

Now the ping works:

$ docker exec -it pihole bash
root@pihole:/# ping google.com
PING google.com (142.250.200.78) 56(84) bytes of data.
64 bytes from mad07s24-in-f14.1e100.net (142.250.200.78): icmp_seq=1 ttl=249 time=3.66 ms
64 bytes from mad07s24-in-f14.1e100.net (142.250.200.78): icmp_seq=2 ttl=249 time=4.13 ms
...

ports:
- target: 53
published: 53
Expand All @@ -32,7 +31,6 @@ services:
- "PROXY_LOCATION=pihole"
- "VIRTUAL_PORT=80"
- "DNS1=172.20.0.3#5053"
- "DNS2=1.1.1.1"
volumes:
- "./etc-pihole/:/etc/pihole/"
- "./etc-dnsmasq.d/:/etc/dnsmasq.d/"
Expand Down