-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release): Add linux arm64 build to matrix #947
Conversation
A hack will need to be implemented to vet that this works in CI (since we don't run post-release on regular CI runs) |
I don't know much about this CI, but if this would have been to be tested within a PR (not the tag or build on main), I would have done a replay with the post-release step as a mandatory step but with staging filename or url, or even a manual sh step with the rust compilation command .... May I be of any help to ease your process / tests ? |
post-release is skipped because it negatively impacts build times when few things change it. We could possibly filter to only run it if post-release itself is changing. So far, it hasn't been worth it because post-release doesn't change much. |
hi @epage, Thanks for your time and help ! |
hi @epage what can I do to help you on this PR ? Stéphane |
I'm not seeing a CI run from when a hack was added to show that the job works |
not sure to understand ... doesn't the CI need to be launch manually ? |
For new contributors, I have to approve a CI run. CI may report a non-blocking failures about commit messages. Separately from that, I want to make sure that the release pipeline will work for the proposed platform. The way to do that is to post an temporary commit that hacks up the release pipeline to kick off for all branches and not create a release, just run the builds. If that is posted and works, ping me. I'll say you can then remove the commit. Ping me again, and I'll merge. |
@epage: Thanks for your help and patience. |
Feel free to revert that change. That change was for an unrelated pipeline but it reminded me that we already do Python wheel releases for aarch64 Linux, so doing it for our Github artifacts should work. |
reverted, thanks ! |
Pull Request Test Coverage Report for Build 9477595845Details
💛 - Coveralls |
Looks like there were still differences in what maturin does as the pipeline failed and I had to revert this. |
so @epage , if I understood correctly, the error is :
which seems not uncommon on cargo: https://stackoverflow.com/questions/28124221/error-linking-with-cc-failed-exit-code-1 |
@epage more infos that I found on the problem if it can help : with links to |
I don't know if that's the correct way to build
I had the same error with an |
we (
jenkins infra team
) would like to use an ARM64 linux version of typos.Reading this issue #828 and this PR #908 it sounds like it was just missing a build block for linux arm64 ... seem a little too easy but I did this at least to make my contribution to the task.