feat(gha): add docker push github action #1116
Conversation
|
this is not tested fully, but I am hopeful this just works. |
|
@epage , this is my "throw this and check if it sticks" I added the manual trigger if you want to play with it manually, before pushing to continuus-deployment if you want me to integrate with other github actions I can spend time on this too |
|
As this is a completely new workflow to me, posting an Action is insufficient. I specifically asked for documentation. I need to understand the workflow and the requirements it places on me. |
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Maybe only fetch 1 depth is sufficient.
There was a problem hiding this comment.
did not find a way to change it to the way you want. I saw the default fetch-depth is 1
| - name: Build and push Docker image | ||
| uses: docker/build-push-action@v6 | ||
| with: | ||
| context: . | ||
| push: true | ||
| tags: ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }}:${{ steps.get_tag.outputs.tag }} |
There was a problem hiding this comment.
We also need to build multi-architecture images alongside the CLI release
There was a problem hiding this comment.
ill do it along the weekend 🍾
There was a problem hiding this comment.
my weekend was not very useful, so found time to push this now
|
oh sorry @epage , I will create the documentation on how this workflow works in addition to the changes requested in the review |
|
@weijiany care to check on your machine? ( I use podman so I just replaced it with docker hoping it just works ) |
|
It is worth noting ChatGPT is a good friend of mine, so he is a co-author. I hope this is ok by you ❤️ |
Hi @georgettica, it works well. ✅ BTW, I am not the repository's maintainer; I am simply a user who wishes to directly utilize the image. |
| tags: ghcr.io/${{ github.repository_owner }}/${{ github.event.repository.name }}:${{ steps.get_tag.outputs.tag }} | ||
| # platforms: linux/arm64/v8,darwin/amd64,linux/amd64,windows/amd64,linux/amd64 # was what I was aiming for | ||
| # but locally I only got to these 3 (specifically linux/arm64/v8 but yeah) | ||
| platforms: linux/arm64,linux/amd64 |
There was a problem hiding this comment.
TBH, I didn't work with on Github action to build multi-arch. But in some pipeline tool that I have used, a question is needn't we to install qemu before building image?’
There was a problem hiding this comment.
That makes sense. I can add it, but I am adding the required tools inside the docker, so I hope it "just works".
|
PS, I accidentally had one of the tools twice: |
|
@weijiany, I guess the only other thing I want to ask so we can move this PR forward is your thoughts and opinions on the documentation I cobbled up. |
For me, the doc is quite clear, possibly because I've reviewed your changes by going through the GitHub Actions documentation. 😅 |
|
Well, at least it's clear. I hope it'll be ok once the actual review comes around |
|
@epage, can I get 👀 ? (sorry for pinging, I don't want this PR to go to waste) |
|
You are in my queue of prs and issues to get to. Be sure the commits are all atomic and organized for how you want me to review and merge this. |
georgettica
force-pushed
the
georgettica/feat/gha/add-docker-push-github-action
branch
from
66b3007
to
91f9eb2
Compare
georgettica
force-pushed
the
georgettica/feat/gha/add-docker-push-github-action
branch
from
91f9eb2
to
0a1a113
Compare
|
I made them into one big blob, as they weren't atomic and some were patch fixes. I am ok with all the PR not passing as it's one atomic change. |
Pull Request Test Coverage Report for Build 11464483713Details
💛 - Coveralls |
fixes #427