Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates stage names in .pre-commit-hooks.yaml. #1114

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

tobiasraabe
Copy link
Contributor

The stage names were updated in pre-commit v4 and the old names are deprecated.

@epage
Copy link
Collaborator

epage commented Oct 7, 2024

The deprecation was added 2 days ago. Whats more important is when the new stage names were added which turns out to be 3.2, see https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md#320---2023-03-17

So they have been around for over a year and a half. Seems reasonable enough of lead time to make this change.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11204334967

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.799%

Totals Coverage Status
Change from base Build 11130620282: 0.0%
Covered Lines: 536
Relevant Lines: 2351

💛 - Coveralls

@epage epage merged commit 2114c19 into crate-ci:master Oct 7, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants