Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple eRSD Tranformer updates #530

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

sliver007
Copy link
Collaborator

Description

  • releaseLabel extension added

  • date and effectivePeriod added to manifest library

  • I've read the contribution guidelines

  • Code compiles without errors

  • Tests are created / updated

  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

- releaseLabel extension added
- date and effectivePeriod added to manifest library
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 21.91%. Comparing base (3babcd0) to head (9d509b4).

Files Patch % Lines
...ing/casereporting/transformer/ErsdTransformer.java 0.00% 21 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #530      +/-   ##
============================================
- Coverage     21.93%   21.91%   -0.03%     
+ Complexity     1672     1671       -1     
============================================
  Files           297      297              
  Lines         25301    25317      +16     
  Branches       3988     3990       +2     
============================================
- Hits           5549     5547       -2     
- Misses        18831    18848      +17     
- Partials        921      922       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival enabled auto-merge (squash) June 6, 2024 15:36
@bryantaustin13 bryantaustin13 self-assigned this Jun 6, 2024
Copy link
Contributor

@bryantaustin13 bryantaustin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds without error

@JPercival JPercival merged commit 92c4c94 into master Jun 6, 2024
4 checks passed
@JPercival JPercival deleted the fix_ersd_transformer_release_label_manifest_dates branch June 6, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants