-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline indicator #877
base: v3
Are you sure you want to change the base?
Offline indicator #877
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -10,3 +10,16 @@ export const ontimeAlertOnDark = { | |||||
color: '#578AF4', // $blue-500 | ||||||
}, | ||||||
}; | ||||||
|
||||||
export const ontimeRedAlertOnDark = { | ||||||
container: { | ||||||
fontSize: 'calc(1rem - 1px)', | ||||||
backgroundColor: '#0000', // $gray-1300 | ||||||
color: '#e2e2e2', // $gray-200 | ||||||
borderRadius: '3px', | ||||||
}, | ||||||
icon: { | ||||||
alignSelf: 'start', | ||||||
color: 'red', // $blue-500 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The comment for the icon color incorrectly references - color: 'red', // $blue-500
+ color: 'red', // Correct color description Committable suggestion
Suggested change
|
||||||
}, | ||||||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
backgroundColor
value'#0000'
seems incorrect as it represents full transparency. Consider using a darker shade appropriate for a dark theme.Committable suggestion