refactor: clear state on sheet flows

cpvalente · Oct 25, 2024 · e0637f6 · e0637f6
1 parent 46e9fcb
commit e0637f6
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 14 deletions.
diff --git a/apps/client/src/features/app-settings/panel/sources-panel/SourcesPanel.tsx b/apps/client/src/features/app-settings/panel/sources-panel/SourcesPanel.tsx
@@ -70,6 +70,17 @@ export default function SourcesPanel() {
     fileInputRef.current?.click();
   };
 
+  const resetFlow = () => {
+    // we purposely omit clearing the authentication status
+    setImportFlow('none');
+    setRundown(null);
+    setHasFile('none');
+    setWorksheets(null);
+    setCustomFields(null);
+    setError('');
+    setSheetId(null);
+  };
+
   const openGSheetFlow = async () => {
     const result = await verifyAuth();
     if (result) {
@@ -89,7 +100,7 @@ export default function SourcesPanel() {
   };
 
   const cancelGSheetFlow = () => {
-    setImportFlow('none');
+    resetFlow();
   };
 
   const handleSubmitImportPreview = async (importMap: ImportMap) => {
@@ -110,9 +121,7 @@ export default function SourcesPanel() {
   };
 
   const cancelImportMap = async () => {
-    setImportFlow('none');
-    setHasFile('none');
-    setWorksheets(null);
+    resetFlow();
     if (authenticationStatus === 'authenticated') {
       const result = await verifyAuth();
       if (result) {
@@ -127,22 +136,14 @@ export default function SourcesPanel() {
     setHasFile('none');
     setWorksheets(null);
     setCustomFields(null);
+    setError('');
   };
 
   const handleSubmitExport = async (importMap: ImportMap) => {
     if (!sheetId) return;
     await exportRundown(sheetId, importMap);
   };
 
-  const resetFlow = () => {
-    setImportFlow('none');
-    setRundown(null);
-    setHasFile('none');
-    setWorksheets(null);
-    setCustomFields(null);
-    setError('');
-  };
-
   const isExcelFlow = importFlow === 'excel';
   const isGSheetFlow = importFlow === 'gsheet';
   const isAuthenticated = authenticationStatus === 'authenticated';

diff --git a/apps/client/src/features/app-settings/panel/sources-panel/import-map/ImportMapForm.tsx b/apps/client/src/features/app-settings/panel/sources-panel/import-map/ImportMapForm.tsx
@@ -121,7 +121,7 @@ export default function ImportMapForm(props: ImportMapFormProps) {
         <thead>
           <tr>
             <th>Ontime field</th>
-            <th>From spreadsheet name</th>
+            <th>Column name in spreadsheet</th>
             <th className={style.singleActionCell} />
           </tr>
         </thead>