Eigen: explicitly disable Fortran usage #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want different packages be created wheter a Fortran compiler is available or not. As Eigen 3.4.0 has no flags to disable the Fortran related code hook into the [CheckLanguge](https://cmake.org/cmake/help/latest/module/CheckLanguage.html) CMake feature. For the variable `CMAKE_<LANG>_COMPILER` the documentation states the following: > If this variable is already set, either explicitly or cached by a previous > call, the check is skipped. We use this to effectively force Eigen to think that there was no Fortan compiler. Fixes the ninja and nmake vs-16-2019 based toolchains.
NeroBurner
added
bug
rbsheth
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want different packages be created wheter a Fortran compiler is available or not. As Eigen 3.4.0 has no flags to disable the Fortran related code hook into the
CheckLanguge CMake feature.
For the variable
CMAKE_<LANG>_COMPILERthe documentation states the following:We use this to effectively force Eigen to think that there was no Fortan compiler.
Fixes the ninja and nmake vs-16-2019 based toolchains.