add new package redis++ including hiredis

[Dargun]

add new packages hiredis and redis++
update libuv to version 1.44.2 and use offical repro for download instead hunter

• I've followed this guide
  step by step carefully. [Yes]

• My change will resolve this "New package" request: https://github.com/cpp-pm/hunter/issues/

---

• I've followed this guide
  step by step carefully. [Yes]

---

I tested all localy with vs-17-2022-win64-cxx17

• examples/redis++
• examples/libuv

[NeroBurner]

please move the libuv update to a new PR, to keep the single PRs small and easy to review

[NeroBurner]

use multiple lines instead of a very long one for better git diffs in the future

and why is the CMAKE_PREFIX_PATH=${HUNTER_INSTALL_PREFIX}) needed? This should be done automatically by hunter

Suggested change

	hunter_cmake_args(Redis++ CMAKE_ARGS REDIS_PLUS_PLUS_BUILD_ASYNC=libuv REDIS_PLUS_PLUS_BUILD_TEST=OFF CMAKE_PREFIX_PATH=${HUNTER_INSTALL_PREFIX})
	hunter_cmake_args(Redis++ CMAKE_ARGS
	REDIS_PLUS_PLUS_BUILD_ASYNC=libuv
	REDIS_PLUS_PLUS_BUILD_TEST=OFF
	)

[Dargun]

i

please move the libuv update to a new PR, to keep the single PRs small and easy to review

had to update libuv so that i'am able to compile redis++

[Dargun]

and why is the CMAKE_PREFIX_PATH=${HUNTER_INSTALL_PREFIX}) needed? This should be done automatically by hunter

this is needed so redis is able to find libuv and hiredis packages.
this is the way they describe in there docs.

[NeroBurner]

link to documentation please

and please try it without. I thought this path is set by Hunter itself and you should not be required to set it as argument

[Dargun]

i tested i localy without CMAKE_PREFIX_PATH=${HUNTER_INSTALL_PREFIX}
but then redis++ is not able to find the libs uvlib and hiredis.

https://github.com/sewenew/redis-plus-plus

If hiredis is installed at non-default location, you should use CMAKE_PREFIX_PATH to specify the installation path of hiredis. By default, redis-plus-plus is installed at /usr/local. However, you can use CMAKE_INSTALL_PREFIX to install redis-plus-plus at non-default location.

[Dargun]

@NeroBurner so i fixed all feedaback from review, how we want proceed?

[NeroBurner]

as mentioned before

please move the libuv update to a new PR, to keep the single PRs small and easy to review

If I've overlooked the libuv PR please ping me there

[NeroBurner]

You'll need to create a fork of redis++ (@rbsheth please fork https://github.com/sewenew/redis-plus-plus ) and add hunter_add_package() calls

documentation at: https://hunter.readthedocs.io/en/latest/creating-new/create/cmake-dependencies.html

[Dargun]

You'll need to create a fork of redis++ (@rbsheth please fork https://github.com/sewenew/redis-plus-plus ) and add hunter_add_package() calls

documentation at: https://hunter.readthedocs.io/en/latest/creating-new/create/cmake-dependencies.html

Creating a fork only for calling hunter_add_package increases the complexity to keep packages up to date for no real reason.
If i want to compile redis++ i need also to link package a and b or more. Whats the issue?

[NeroBurner]

yes, the overhead of forks is a known issue (unfortunately). But the goal of Hunter is to provide the dependency for the project with all the other dependencies. Otherwise dependency hell breaks loose

More on this topic with detailed explanation why we need forks: https://hunter.readthedocs.io/en/latest/faq/why-do-we-need-forks.html

[NeroBurner]

please add the package to at least one of the already listed index-groups

https://hunter.readthedocs.io/en/latest/genindex.html

[NeroBurner]

please add the package to at least one of the already listed index-groups

https://hunter.readthedocs.io/en/latest/genindex.html

[NeroBurner]

needed? if not please remove

[NeroBurner]

needed? if not please remove

[rbsheth]

https://github.com/cpp-pm/redis-plus-plus