[health] Add getHealthConnectSdkStatus #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Health release 10.0.0
Health version 10.1.0
ciriousjoker
changed the title
ciriousjoker
force-pushed
the
health_getHealthConnectStatus
branch
from
57a132e
to
f096bd4
Compare
ciriousjoker
changed the title
ciriousjoker
force-pushed
the
health_getHealthConnectStatus
branch
2 times, most recently
from
ffc27af
to
82edf4d
Compare
ciriousjoker
force-pushed
the
health_getHealthConnectStatus
branch
from
82edf4d
to
ddbb06d
Compare
ciriousjoker
commented
Apr 2, 2024
| requestPermissionActivityContract | ||
| ) { granted -> onHealthConnectPermissionCallback(granted) } | ||
| } | ||
| healthConnectRequestPermissionsLauncher = |
There was a problem hiding this comment.
This needs to always be done now since doing it later (after the user installed Health Connect) is no longer possible.
ciriousjoker
commented
Apr 2, 2024
| @@ -2449,6 +2448,17 @@ class HealthPlugin(private var channel: MethodChannel? = null) : | |||
| result.success(null) | |||
| } | |||
|
|
|||
| private fun getHealthConnectSdkStatus(call: MethodCall, result: Result) { | |||
| checkAvailability() | |||
| if (healthConnectAvailable) { | |||
There was a problem hiding this comment.
Availability could have changed since the sdk was set up, so we need to make sure the client exists in those cases or the other methods will crash.
bardram
approved these changes
Apr 3, 2024
Merged
|
This has now been released in 10.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested to work on a API Level 28 emulator.