Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Health] Add empty value check for calories nutrition #926

Conversation

shubhamsinghmutualmobile
Copy link
Contributor

@shubhamsinghmutualmobile shubhamsinghmutualmobile commented Mar 26, 2024

This PR fixes #925

Demo (iOS)

We don't have to provide unnecessary nutrition permissions anymore. In this example, I only wanted to add caffeine, hence, I only had to provide its permission.

Screen.Recording.2024-03-26.at.8.20.44.PM.mov

@shubhamsinghmutualmobile shubhamsinghmutualmobile changed the title Add empty value check for calories nutrition [Health] Add empty value check for calories nutrition Mar 26, 2024
@bardram bardram changed the base branch from master to bardram/health-update March 30, 2024 10:14
@bardram bardram self-assigned this Mar 30, 2024
bardram added a commit that referenced this pull request Mar 30, 2024
@bardram bardram mentioned this pull request Mar 30, 2024
@bardram
Copy link
Contributor

bardram commented Mar 30, 2024

Released as version 10.1.0

@ciriousjoker
Copy link
Contributor

ciriousjoker commented Mar 30, 2024

@bardram
Unfortunately this broke compilation:

Also why did you "close" this when it's actually "merged"?

@ciriousjoker ciriousjoker mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health (9.0.1) - Allow individual nutrition values to be written
5 participants