-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Health] improve support for sleep stages #1026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2024
This was
linked to
issues
Aug 23, 2024
bardram
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, not all the sleep stages that are supported in HealthKit and Health Connect were supported in the Health package. On the iOS side, some of the sleep stages were supported but undocumented. This PR improves support and documentation for all possible sleep stages across both platforms:
Closes #985.
Overview of the changes
SLEEP_CORE
was renamed toSLEEP_LIGHT
to be consistent with Android, as HealthKit documentation states that theasleepCore
stage includes "light sleep".SLEEP_UNKNOWN
andSLEEP_AWAKE_IN_BED
.SLEEP_ASLEEP_CORE
,SLEEP_ASLEEP_DEEP
,SLEEP_ASLEEP_REM
and combine them into the previously existing Android stages:SLEEP_DEEP
,SLEEP_REM
(and as previously mentionedSLEEP_ASLEEP_CORE
becomesSLEEP_LIGHT
.SLEEP_ASLEEP
on iOS previously referred toasleepCore
, which is incorrect - it should refer to when the user is asleep but the sleep stage cannot be determined, and as such it now refers toasleepUnspecified
.