[WIP] Port from STORM to peewee and add python3 support #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieterdavid
changed the title
pieterdavid
changed the title
for python3 compatibility. At this point search_SAMADhi.py works from a python3 pip-installed version - much more testing needed.
added --database argument to command-line script, to use an alternative database (which may be an sqlite file for testing)
- setup.cfg: alias such that 'python setup.py test' runs pytest - import cppyy instead of ROOT (avoid atexit error with setup.py test) - silence mysql version warning also outside CMSSW - update .gitignore
…(future package) for python3.7 compatibility
|
First dataset added with this branch is here, I will add some more 2018 samples to check that everything is working. |
…ey logically belong with, and use entry_points/console_scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These go together since the reason to change ORM library was to also support python3. Since this meant touching most code anyway, I took advantage to do a bit of cleanup and modernisation here and there.
Current status: tests with a small local database show that the basic functionality works (but these don't cover all possible cases). Also search_SAMADhi.py seems to behave correctly, the models should be largely compatible with the production database, but the other scripts need more testing with that (next would be the 'add_*' scripts and dbAnalysis, then checkAndClean in dryrun mode; is there some way to protect against messing up while doing this?), and there are also some scripts in GridIn that need to be ported.