Skip to content

Commit

Permalink
Fix query id for slippage accounting (#323)
Browse files Browse the repository at this point in the history
The change to the `period_slippage.sql` query in #322 did not change the
dune query called from the code. This resulted in wrong slippage
computations from this repository. The Dune dashboards already showed
the correct slippage.
In this PR, the code in `queries.py` is changed to point to a new Dune
query created by cowprotocol. The code of that query is identical to
`period_slippage.sql`.
  • Loading branch information
fhenneke authored Oct 11, 2023
1 parent 005c75d commit 21510af
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion queries/dune_v2/period_slippage.sql
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
-- https://github.com/cowprotocol/solver-rewards/pull/322
-- Query Here: https://dune.com/queries/2421375
-- Query Here: https://dune.com/queries/3093726
with
batch_meta as (
select b.block_time,
Expand Down
2 changes: 1 addition & 1 deletion src/queries.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def with_params(self, params: list[QueryParameter]) -> Query:
"PERIOD_SLIPPAGE": QueryData(
name="Solver Slippage for Period",
filepath="period_slippage.sql",
q_id=2421375,
q_id=3093726,
),
"DASHBOARD_SLIPPAGE": QueryData(
name="Period Solver Rewards",
Expand Down

0 comments on commit 21510af

Please sign in to comment.