fix: indexed address within interface #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedgiac
approved these changes
Jul 18, 2024
The interface shared with the balancer team already had this value |
MartinquaXD
added a commit
to cowprotocol/services
that referenced
this pull request
Jul 18, 2024
# Description Our implementation of the cow amm helper contract needed to generate rebalancing orders was very slightly different from the agreed upon interface. This difference prevented us from indexing balancer pools correctly. To support the legacy and balancer pools at the same time both factory implementations need to adhere to the exact same interface (actually just the emitted events). This PR updates the interface and all related deployment info based on cowprotocol/cow-amm#99. # Changes Also the new helper contract returns a slightly different signature which already includes the signer address (expected by the settlement contract). This should generally be nicer for people using the helper but in our code base we expect the signer address to not already be part of the signature bytes so we needed to introduce a small workaround (with comment explaining why). Note that the helper contract for the balancer [implementation](https://etherscan.io/address/0xE50481D88f147B8b4aaCdf9a1B7b7bA44F87823f#code) has the same behavior so everything should work out. I also removed the deployment information for `sepolia` since the helper contract actually supports 0 pools there so we might as well drop it altogether on `sepolia`. ## How to test e2e tests still work
MartinquaXD
added a commit
to cowprotocol/services
that referenced
this pull request
Jul 18, 2024
# Description Our implementation of the cow amm helper contract needed to generate rebalancing orders was very slightly different from the agreed upon interface. This difference prevented us from indexing balancer pools correctly. To support the legacy and balancer pools at the same time both factory implementations need to adhere to the exact same interface (actually just the emitted events). This PR updates the interface and all related deployment info based on cowprotocol/cow-amm#99. # Changes Also the new helper contract returns a slightly different signature which already includes the signer address (expected by the settlement contract). This should generally be nicer for people using the helper but in our code base we expect the signer address to not already be part of the signature bytes so we needed to introduce a small workaround (with comment explaining why). Note that the helper contract for the balancer [implementation](https://etherscan.io/address/0xE50481D88f147B8b4aaCdf9a1B7b7bA44F87823f#code) has the same behavior so everything should work out. I also removed the deployment information for `sepolia` since the helper contract actually supports 0 pools there so we might as well drop it altogether on `sepolia`. ## How to test e2e tests still work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
COWAMMPoolCreatedcomplies (i.e. the address isindexed).