Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cow amm safe module #33

Merged
merged 6 commits into from
Feb 27, 2024
Merged

feat: cow amm safe module #33

merged 6 commits into from
Feb 27, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Feb 23, 2024

This PR:

  1. Creates a CoW AMM safe module that handles the automating of safe configuration for CoW AMMs.

@mfw78 mfw78 added the enhancement New feature or request label Feb 23, 2024
@mfw78 mfw78 requested a review from a team February 23, 2024 09:16
@mfw78 mfw78 self-assigned this Feb 23, 2024
fedgiac
fedgiac reviewed Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly high-level comments on the current design.
Overall, I think it's a big improvement over the current deployment mechanism in the docs and we should recommend it. There are a few relatively small changes I'd like to see, however.

src/CowAmmModule.sol Outdated Show resolved Hide resolved
src/CowAmmModule.sol Outdated Show resolved Hide resolved
src/CowAmmModule.sol Outdated Show resolved Hide resolved
src/CowAmmModule.sol Outdated Show resolved Hide resolved
src/CowAmmModule.sol Show resolved Hide resolved
src/CowAmmModule.sol Outdated Show resolved Hide resolved
@mfw78 mfw78 marked this pull request as ready for review February 25, 2024 08:59
@mfw78 mfw78 requested a review from fleupold February 25, 2024 08:59
@mfw78
Copy link
Contributor Author

mfw78 commented Feb 25, 2024

Ready for review, test suite coming in a subsequent PR

fleupold
fleupold approved these changes Feb 25, 2024
View reviewed changes
src/CowAmmModule.sol Show resolved Hide resolved
src/CowAmmModule.sol Show resolved Hide resolved
fedgiac
fedgiac approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
There are some minor suggestion, but I'm not sure they are worth a redeployment on mainnet.

src/CowAmmModule.sol Outdated Show resolved Hide resolved
src/CowAmmModule.sol Outdated Show resolved Hide resolved
@fedgiac fedgiac mentioned this pull request Feb 27, 2024
Merged
@mfw78 mfw78 merged commit fd5cf1a into main Feb 27, 2024
3 checks passed
@mfw78 mfw78 deleted the cow-amm-module branch February 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedgiac fedgiac fedgiac approved these changes

@fleupold fleupold fleupold approved these changes

Assignees

@mfw78 mfw78

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfw78 @fleupold @fedgiac