Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mainnet deployments #30

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Add mainnet deployments #30

merged 1 commit into from
Feb 22, 2024

Conversation

fedgiac
Copy link
Collaborator

@fedgiac fedgiac commented Feb 21, 2024

Adds artifacts from contract deployments on mainnet.

This deployment was dirty. I executed:

forge script 'script/DeployAllContracts.s.sol:DeployAllContracts' -vvvv --rpc-url "$ETH_RPC_URL" --verify --broadcast --private-key "$PK"

But the gas price increased between the time of simulation and the time of execution, and so the third transaction failed, since there weren't enough funds in the deployer to pay for it anymore ((code: -32010, message: InsufficientFunds, Account balance: 391884345774399636, cumulative cost: 397714356026954136, data: None)).

Since it would be a waste of ETH to relaunch the full deployment script, I decided to just run the deployment script for the remaining contract once the gas price decreased a bit:

forge script 'script/single-deployment/BalancerWeightedPoolPriceOracle.s.sol:DeployBalancerWeightedPoolPriceOracle' -vvvv --rpc-url "$ETH_RPC_URL"   --private-key "$PK"

This is why there are two files in broadcast/.

I also updated the script that updates networks.json to ignore contract creations without a transaction and used it to generate that file.

How to test

Check out networks.json and confirm that the verified contract code matches the expected contracts.

@fedgiac fedgiac requested a review from a team February 21, 2024 16:49
@fedgiac fedgiac merged commit 490a7ab into main Feb 22, 2024
3 checks passed
@fedgiac fedgiac deleted the updated-mainnet-deployments branch February 22, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants