Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct control over openzeppelin dependency #27

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

fedgiac
Copy link
Collaborator

@fedgiac fedgiac commented Feb 20, 2024

Currently, we use a library that comes from a dependency of the composable-cow dependency.
This means that updating composable-cow could lead to also updating openzeppelin, which might not be intended.

This PR only changes our use of libraries: we still preserve interfaces from subdependencies for ease of integration with composable-cow. For now, we try to avoid remappings.

How to test

Verify that the dependency points to the same commit as the dependency in composable-cow (tag v4.9.3).

$ (cd lib/composable-cow/lib/@openzeppelin/ && git rev-parse HEAD)
fd81a96f01cc42ef1c9a5399364968d0e07e9e90
$ (cd lib/openzeppelin/ && git rev-parse HEAD)
fd81a96f01cc42ef1c9a5399364968d0e07e9e90

@fedgiac fedgiac requested a review from a team February 20, 2024 13:41
@mfw78
Copy link
Contributor

mfw78 commented Feb 22, 2024

FYI, one for us to keep an eye on: https://github.com/OpenZeppelin/openzeppelin-contracts#foundry-git (refer warnings about forge update). Not the case on this PR though 🙂

@fedgiac fedgiac merged commit 3689d24 into main Feb 22, 2024
3 checks passed
@fedgiac fedgiac deleted the direct-control-over-openzeppelin-dependency branch February 22, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants