Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add devcontainer #2

Merged
merged 4 commits into from
Apr 2, 2024
Merged

chore: add devcontainer #2

merged 4 commits into from
Apr 2, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Jan 26, 2024

This PR:

  1. Configures a devcontainer for smart contract development in foundry.

@mfw78 mfw78 added the enhancement New feature or request label Jan 26, 2024
@mfw78 mfw78 requested a review from a team January 26, 2024 15:17
@mfw78 mfw78 self-assigned this Jan 26, 2024
Copy link
Collaborator

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out the dev container and everything looks fine in my very limited understanding of dev containers.
The Solidity VSCode extension wasn't installed automatically, but I believe this is an issue of my quite fragile setup (vscodium & open-remote-ssh & devpod).

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@mfw78 mfw78 merged commit 0d6bb45 into main Apr 2, 2024
3 checks passed
@mfw78 mfw78 deleted the devcontainer branch April 2, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants