Fix tests #709
Merged
Fix tests #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provider template is deprecated. This provider has been used extensively in tests (both in the upstream Terragrunt and within our fork) because `data.template_file` was seen as a simple Terraform resource that didn’t produce any real artifacts. However, while the Linux versions are still available for download, the Windows and OSX/Darwin versions are no longer offered, causing test failures in local setups on Mac or Windows. This makes it challenging to add or modify tests locally.
jonapich
approved these changes
Oct 3, 2024
jocgir
deleted the
DT-7244-Remove-template_file-data-resource-from-all-tests-in-Terragrunt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the Terraform versions in the workflow configuration, simplifications of test functions, and removal of redundant
template_filedata sources in multiple test fixtures.Workflow and Configuration Updates:
.github/workflows/pr.yml: Updated Terraform versions from1.0.2,1.3.8, and1.4.0to1.7.5,1.8.5, and1.9.7.Test Function Simplifications:
configstack/module_test.go: Removed thetparameter from thestatefunction calls in multiple test functions to simplify the code. [1] [2] [3] [4]configstack/stack_test.go: Simplified thecreateTempFolderfunction by removing thetparameter and usingos.TempDir()directly. [1] [2]configstack/test_helpers.go: Removed thetparameter from thestatefunction.Removal of Redundant Data Sources:
test/fixture-download/hello-world-with-backend/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-download/hello-world/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-download/local-relative-extra-args-windows/JZwoL6Viko8bzuRvTOQFx3Jh8vs/3mU4huxMLOXOW5ZgJOFXGUFDKc8/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-gotemplate/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-hooks/after-only/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-hooks/before-and-after-merge/qa/my-app/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-hooks/before-and-after/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-hooks/before-only/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-hooks/exitcode-1-run-on-errors/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-hooks/exitcode-1/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-hooks/exitcode-2-pre/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-hooks/exitcode-2/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-hooks/ignore-error/main.tf: Removed thetemplate_filedata source and updated the output accordingly.test/fixture-hooks/interpolations/main.tf: Removed thetemplate_filedata source and updated the output accordingly.The provider template is deprecated. This provider has been used extensively in tests (both in the upstream Terragrunt and within our fork) becausedata.template_filewas seen as a simple Terraform resource that didn’t produce any real artifacts. However, while the Linux versions are still available for download, the Windows and OSX/Darwin versions are no longer offered, causing test failures in local setups on Mac or Windows. This makes it challenging to add or modify tests locally.