Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(atomic): add variable for collapsed rga height #4633

Open
wants to merge 6 commits into
base: v2
Choose a base branch
from

Conversation

dguerinCoveo
Copy link
Contributor

Following this PR. Backporting the variable addition to V2 to be able to support the feature ASAP in the builders.

@dguerinCoveo dguerinCoveo requested a review from a team as a code owner November 5, 2024 18:28
@dguerinCoveo dguerinCoveo changed the title Feat/svcc 4300 v2 feat(atomic): add variable for collapsed rga height Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.5 244.5 0
commerce 343.1 343.1 0
search 417.2 417.2 0
insight 395 395 0
product-listing 306.8 306.8 0
product-recommendation 215.3 215.3 0
recommendation 257.7 257.7 0
ssr 407.7 407.7 0
ssr-commerce 353.7 353.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@dguerinCoveo dguerinCoveo added this pull request to the merge queue Nov 5, 2024
@dguerinCoveo dguerinCoveo removed this pull request from the merge queue due to a manual request Nov 5, 2024
@dguerinCoveo dguerinCoveo added this pull request to the merge queue Nov 5, 2024
@dguerinCoveo dguerinCoveo removed this pull request from the merge queue due to a manual request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants