-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quantic): Exposed clearFilters option in quantic searchboxes #4606
Conversation
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
packages/quantic/force-app/main/default/lwc/quanticSearchBox/quanticSearchBox.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSearchBox/__tests__/quanticSearchBox.test.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSearchBox/__tests__/quanticSearchBox.test.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSearchBox/__tests__/quanticSearchBox.test.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSearchBox/__tests__/quanticSearchBox.test.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSearchBox/__tests__/quanticSearchBox.test.js
Outdated
Show resolved
Hide resolved
.../quantic/force-app/main/default/lwc/quanticStandaloneSearchBox/quanticStandaloneSearchBox.js
Outdated
Show resolved
Hide resolved
fa428e3
to
28e3f5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job 👍
couple more comments and there is the following issue that's occurring with the unit tests of the standalone search box that need to be fixed: https://github.com/coveo/ui-kit/actions/runs/11598185613/job/32293878598?pr=4606
...app/main/default/lwc/quanticStandaloneSearchBox/__tests__/quanticStandaloneSearchBox.test.js
Outdated
Show resolved
Hide resolved
...tic/force-app/main/default/lwc/quanticStandaloneSearchBox/templates/standaloneSearchBox.html
Show resolved
Hide resolved
will mute the console error |
It's important to figure out the WHY before muting or doing any actions. Because this did not appear with other tests, only with this one. |
4136cea
to
86412e1
Compare
fixed that by mocking the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
...app/main/default/lwc/quanticStandaloneSearchBox/__tests__/quanticStandaloneSearchBox.test.js
Outdated
Show resolved
Hide resolved
2763b6f
to
6136f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
packages/quantic/force-app/main/default/lwc/quanticSearchBox/quanticSearchBox.js
Show resolved
Hide resolved
...app/main/default/lwc/quanticStandaloneSearchBox/__tests__/quanticStandaloneSearchBox.test.js
Show resolved
Hide resolved
ae4c91a
to
73505e6
Compare
SFINT-5785
IN THIS PR:
keepFiltersOnSearch
properties on thequanticSearchBox
andquanticStandaloneSearchBox
that defaults to false (sinceclearFilters
is enabled by default). Setting this totrue
makes it possible to not clear the facets after triggering a search (see demo below)keepFiltersOnSearch
is true/falseDEMO:
Screen.Recording.2024-10-28.at.1.34.03.PM.mov