-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(answerAPI): insight generate endpoint #4602
feat(answerAPI): insight generate endpoint #4602
Conversation
2040fff
to
433aa31
Compare
433aa31
to
972d40c
Compare
972d40c
to
8653fa2
Compare
packages/headless/src/api/knowledge/tests/stream-answer-api-state-mock.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approved a bit too quickly ;)
The build is failing and you need to change a few things.
Co-authored-by: Frederic Beaudoin <[email protected]>
Co-authored-by: Frederic Beaudoin <[email protected]>
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
@fbeaudoincoveo @alexprudhomme Did apply your suggestion and ready for another round !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Answer API
SVCC-4265
Support for the insight specific endpoint
The insight panels require a specific generate endpoint because their query pipeline is not exposed and thus it cannot be passed to the generate call from the client. The new endpoint is managing this from under the hood if we pass an InsightConfiguration