Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(answerAPI): insight generate endpoint #4602

Merged

Conversation

dmgauthier
Copy link
Contributor

@dmgauthier dmgauthier commented Oct 28, 2024

Answer API

SVCC-4265

Support for the insight specific endpoint

The insight panels require a specific generate endpoint because their query pipeline is not exposed and thus it cannot be passed to the generate call from the client. The new endpoint is managing this from under the hood if we pass an InsightConfiguration

@dmgauthier dmgauthier force-pushed the feat-SVCC-4265-answer-api-insight-generate-endpoint branch 2 times, most recently from 2040fff to 433aa31 Compare October 28, 2024 19:50
@dmgauthier dmgauthier force-pushed the feat-SVCC-4265-answer-api-insight-generate-endpoint branch from 433aa31 to 972d40c Compare October 29, 2024 17:42
@dmgauthier dmgauthier marked this pull request as ready for review October 29, 2024 17:43
@dmgauthier dmgauthier requested a review from a team as a code owner October 29, 2024 17:43
@dmgauthier dmgauthier force-pushed the feat-SVCC-4265-answer-api-insight-generate-endpoint branch from 972d40c to 8653fa2 Compare October 29, 2024 17:46
Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved a bit too quickly ;)

The build is failing and you need to change a few things.

packages/headless/src/api/knowledge/stream-answer-api.ts Outdated Show resolved Hide resolved
packages/headless/src/api/knowledge/stream-answer-api.ts Outdated Show resolved Hide resolved
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.7 0.1
commerce 341.5 341.6 0
search 412.3 412.4 0
insight 401.6 401.7 0
recommendation 248.8 248.9 0.1
ssr 406 406.1 0
ssr-commerce 353.8 353.9 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@dmgauthier
Copy link
Contributor Author

@fbeaudoincoveo @alexprudhomme Did apply your suggestion and ready for another round !!

@dmgauthier dmgauthier added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2024
Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@dmgauthier dmgauthier added this pull request to the merge queue Nov 5, 2024
Merged via the queue into master with commit 16f2e56 Nov 5, 2024
121 checks passed
@dmgauthier dmgauthier deleted the feat-SVCC-4265-answer-api-insight-generate-endpoint branch November 5, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants