Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: promote the v3 branch when publishing on v3 #4585

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Oct 22, 2024

Sames as #4584 for v3

Technically, we could "just fix" the script.
However, I think it's best to make it "fit" with the rest of our release scripts in its code architecture while keeping the same functionality

https://coveord.atlassian.net/browse/KIT-3668

Copy link

github-actions bot commented Oct 22, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.6 0
commerce 340.5 340.5 0
search 412 412 0
insight 400 400 0
recommendation 248.8 248.8 0
ssr 405.7 405.7 0
ssr-commerce 352.8 352.8 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart changed the title chore: promote the v2 branch when publishing on v3 chore: promote the v3 branch when publishing on v3 Oct 23, 2024
@fbeaudoincoveo
Copy link
Contributor

Please add Jira number in description when you merge

@louis-bompart louis-bompart added this pull request to the merge queue Oct 23, 2024
Merged via the queue into master with commit 7b9144d Oct 23, 2024
97 checks passed
@louis-bompart louis-bompart deleted the npm-prod-script branch October 23, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants