Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(atomic): fix flaky atomic-external tests #4515

Merged
merged 2 commits into from
Oct 10, 2024
Merged

test(atomic): fix flaky atomic-external tests #4515

merged 2 commits into from
Oct 10, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Oct 9, 2024 •
edited
Loading

@alexprudhomme alexprudhomme requested a review from a team as a code owner October 9, 2024 19:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.8 236.8 0
commerce 339.6 339.6 0
search 412.3 412.3 0
insight 400.4 400.4 0
recommendation 249 249 0
ssr 406 406 0
ssr-commerce 351.9 351.9 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme enabled auto-merge (squash) October 10, 2024 14:20
@alexprudhomme alexprudhomme merged commit d207ff5 into master Oct 10, 2024
114 checks passed
@alexprudhomme alexprudhomme deleted the CDX-1594 branch October 10, 2024 14:41
fpbrault pushed a commit that referenced this pull request Oct 10, 2024
@alexprudhomme @fpbrault
test(atomic): fix flaky atomic-external tests (#4515)
ff63584 
https://coveord.atlassian.net/browse/CDX-1594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@louis-bompart louis-bompart Awaiting requested review from louis-bompart louis-bompart is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexprudhomme @fbeaudoincoveo