-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(atomic): run only affected E2E tests in atomic #4484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-lakhdar
changed the title
poc(scope e2e test): run only affected E2E tests in atomic
poc(atomic): run only affected E2E tests in atomic
Oct 2, 2024
y-lakhdar
commented
Oct 2, 2024
packages/atomic/src/components/recommendations/atomic-recs-list/atomic-recs-list.tsx
Show resolved
Hide resolved
y-lakhdar
commented
Oct 2, 2024
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
y-lakhdar
had a problem deploying
to
PR Artifacts
October 3, 2024 13:44
— with
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
October 7, 2024 20:42
— with
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
October 8, 2024 13:40
— with
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
October 8, 2024 13:56
— with
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
October 8, 2024 14:31
— with
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
October 8, 2024 14:48
— with
GitHub Actions
Failure
y-lakhdar
changed the title
poc(atomic): run only affected E2E tests in atomic
ci(atomic): run only affected E2E tests in atomic
Oct 8, 2024
louis-bompart
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's try it!
louis-bompart
temporarily deployed
to
PR Artifacts
October 10, 2024 18:11
— with
GitHub Actions
Inactive
alexprudhomme
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, ran 1 out of 1 shard 😄
louis-bompart
temporarily deployed
to
PR Artifacts
October 10, 2024 18:22
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to optimize the E2E tests by running only the affected tests.
Identifying only the affected tests by listing the changed files can be tricky in the case of E2E testing. However, since we are testing components in isolation, we can use this approach along with TypeScript AST (Abstract Syntax Tree) to build a tree representation of the atomic code structure. This allows us to create a dependency map between each E2E test file and all the source files that might affect them.
Rules
Shard reduction
I also adjusted the number of shards based on the number of results. 1 shard per test suite (24 shard max)
https://coveord.atlassian.net/browse/KIT-3634