Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip sample build for cdn #4460

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Sep 25, 2024

https://coveord.atlassian.net/browse/KIT-3602

Copy what was in the angular sample and other sample relying on Atomic, for the same reason (but expanded to all the sample now that Bueno is an external of Headless).

Will be revisited in post-ga tech debts

Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 235.9 235.9 0
commerce 339.1 339.1 0
search 409.5 409.5 0
insight 395.4 395.4 0
recommendation 248.5 248.5 0
ssr 403.5 403.5 0
ssr-commerce 351.4 351.4 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart merged commit 593f10b into master Sep 25, 2024
112 checks passed
@louis-bompart louis-bompart deleted the ci/skip-sample-build-for-cdn branch September 25, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants