-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add package compatibility tests using publint #4446
Merged
Merged
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4c3d793 - Browse repository at this point
Copy the full SHA 4c3d793View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8896adb - Browse repository at this point
Copy the full SHA 8896adbView commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d4f9150 - Browse repository at this point
Copy the full SHA d4f9150View commit details -
Configuration menu - View commit details
-
Copy full SHA for d65b94c - Browse repository at this point
Copy the full SHA d65b94cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad2e6f8 - Browse repository at this point
Copy the full SHA ad2e6f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbae835 - Browse repository at this point
Copy the full SHA bbae835View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6264b8 - Browse repository at this point
Copy the full SHA c6264b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d232fd - Browse repository at this point
Copy the full SHA 8d232fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 062e6e7 - Browse repository at this point
Copy the full SHA 062e6e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d8345d - Browse repository at this point
Copy the full SHA 6d8345dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c48774 - Browse repository at this point
Copy the full SHA 4c48774View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c5d357 - Browse repository at this point
Copy the full SHA 4c5d357View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c7e7fa - Browse repository at this point
Copy the full SHA 7c7e7faView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4ebfab - Browse repository at this point
Copy the full SHA a4ebfabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 395a91c - Browse repository at this point
Copy the full SHA 395a91cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 872438d - Browse repository at this point
Copy the full SHA 872438dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dc0016 - Browse repository at this point
Copy the full SHA 3dc0016View commit details -
Update packages/atomic/.storybook/main.mts
Co-authored-by: Alex Prudhomme <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 38f7b3a - Browse repository at this point
Copy the full SHA 38f7b3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39fe585 - Browse repository at this point
Copy the full SHA 39fe585View commit details -
Configuration menu - View commit details
-
Copy full SHA for 480b5bb - Browse repository at this point
Copy the full SHA 480b5bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95c6b60 - Browse repository at this point
Copy the full SHA 95c6b60View commit details -
Configuration menu - View commit details
-
Copy full SHA for c999749 - Browse repository at this point
Copy the full SHA c999749View commit details -
Configuration menu - View commit details
-
Copy full SHA for daadc1d - Browse repository at this point
Copy the full SHA daadc1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b70bdde - Browse repository at this point
Copy the full SHA b70bddeView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2de421 - Browse repository at this point
Copy the full SHA b2de421View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2207b51 - Browse repository at this point
Copy the full SHA 2207b51View commit details -
All errors are fixed. Warnings left that I cant fix : 1. The types errors for commonJS are not urgent 2. I can't find how to tell stencil to generate commonjs files as .cjs instead of .js ``` npx publint ./node_modules/@coveo/atomic-react @coveo/atomic-react lint results: Warnings: 1. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/index.d.cts" npx publint ./node_modules/@coveo/atomic @coveo/atomic lint results: Warnings: 1. pkg.main is dist/index.cjs.js and is written in CJS, but is interpreted as ESM. Consider using the .cjs extension, e.g. dist/index.cjs.cjs 3. pkg.exports["."].require is ./dist/index.cjs.js and is written in CJS, but is interpreted as ESM. Consider using the .cjs extension, e.g. ./dist/index.cjs.cjs 4. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/types/index.d.cts" 5. pkg.exports["./loader"].import is ./loader/index.js and is written in ESM, but is interpreted as CJS. Consider using the .mjs extension, e.g. ./loader/index.mjs npx publint ./node_modules/@coveo/headless @coveo/headless lint results: Warnings: 1. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/definitions/index.d.cts" ```
Configuration menu - View commit details
-
Copy full SHA for 015040f - Browse repository at this point
Copy the full SHA 015040fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8795d9c - Browse repository at this point
Copy the full SHA 8795d9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 921168c - Browse repository at this point
Copy the full SHA 921168cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4db6223 - Browse repository at this point
Copy the full SHA 4db6223View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0715277 - Browse repository at this point
Copy the full SHA 0715277View commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3d0fc63 - Browse repository at this point
Copy the full SHA 3d0fc63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78f5bda - Browse repository at this point
Copy the full SHA 78f5bdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97cbe45 - Browse repository at this point
Copy the full SHA 97cbe45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44c6ee2 - Browse repository at this point
Copy the full SHA 44c6ee2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7858d1 - Browse repository at this point
Copy the full SHA f7858d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2869bb9 - Browse repository at this point
Copy the full SHA 2869bb9View commit details
Commits on Sep 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b551c24 - Browse repository at this point
Copy the full SHA b551c24View commit details -
Configuration menu - View commit details
-
Copy full SHA for a08c38f - Browse repository at this point
Copy the full SHA a08c38fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdee62a - Browse repository at this point
Copy the full SHA cdee62aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fca54e1 - Browse repository at this point
Copy the full SHA fca54e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58d9c32 - Browse repository at this point
Copy the full SHA 58d9c32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a27083 - Browse repository at this point
Copy the full SHA 7a27083View commit details
Commits on Oct 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d21fb11 - Browse repository at this point
Copy the full SHA d21fb11View commit details -
Configuration menu - View commit details
-
Copy full SHA for f33c442 - Browse repository at this point
Copy the full SHA f33c442View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19a73d5 - Browse repository at this point
Copy the full SHA 19a73d5View commit details
Commits on Oct 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bc80970 - Browse repository at this point
Copy the full SHA bc80970View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.