Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add package compatibility tests using publint #4446

Merged
merged 47 commits into from
Oct 23, 2024
Merged

Commits on Sep 19, 2024

  1. type module everywhere

    louis-bompart committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    4c3d793 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8896adb View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. lint&ut

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d4f9150 View commit details
    Browse the repository at this point in the history
  2. e2e should be fine

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d65b94c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad2e6f8 View commit details
    Browse the repository at this point in the history
  4. fix typedoc

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    bbae835 View commit details
    Browse the repository at this point in the history
  5. deps

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c6264b8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8d232fd View commit details
    Browse the repository at this point in the history
  7. missing patch

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    062e6e7 View commit details
    Browse the repository at this point in the history
  8. tweak-cypresses

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6d8345d View commit details
    Browse the repository at this point in the history
  9. fixlint

    louis-bompart committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    4c48774 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4c5d357 View commit details
    Browse the repository at this point in the history
  11. Delete action.yml

    alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7c7e7fa View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a4ebfab View commit details
    Browse the repository at this point in the history
  13. typo

    alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    395a91c View commit details
    Browse the repository at this point in the history
  14. typo

    alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    872438d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    3dc0016 View commit details
    Browse the repository at this point in the history
  16. Update packages/atomic/.storybook/main.mts

    Co-authored-by: Alex Prudhomme <[email protected]>
    louis-bompart and alexprudhomme authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    38f7b3a View commit details
    Browse the repository at this point in the history
  17. Update package.json

    alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    39fe585 View commit details
    Browse the repository at this point in the history
  18. typo ahh

    alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    480b5bb View commit details
    Browse the repository at this point in the history
  19. Revert "typo ahh"

    This reverts commit 480b5bb.
    alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    95c6b60 View commit details
    Browse the repository at this point in the history
  20. Update package.json

    alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c999749 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    daadc1d View commit details
    Browse the repository at this point in the history
  22. changes forgotten

    alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b70bdde View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    b2de421 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    2207b51 View commit details
    Browse the repository at this point in the history
  25. fix errors (#4444)

    All errors are fixed.
    
    Warnings left that I cant fix : 
    1. The types errors for commonJS are not urgent
    2. I can't find how to tell stencil to generate commonjs files as .cjs
    instead of .js
    
    ```
     npx publint ./node_modules/@coveo/atomic-react
    @coveo/atomic-react lint results:
    Warnings:
    1. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/index.d.cts"
    
    
     npx publint ./node_modules/@coveo/atomic
    @coveo/atomic lint results:
    Warnings:
    1. pkg.main is dist/index.cjs.js and is written in CJS, but is interpreted as ESM. Consider using the .cjs extension, e.g. dist/index.cjs.cjs
    3. pkg.exports["."].require is ./dist/index.cjs.js and is written in CJS, but is interpreted as ESM. Consider using the .cjs extension, e.g. ./dist/index.cjs.cjs
    4. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/types/index.d.cts"
    5. pkg.exports["./loader"].import is ./loader/index.js and is written in ESM, but is interpreted as CJS. Consider using the .mjs extension, e.g. ./loader/index.mjs
    
    
    npx publint ./node_modules/@coveo/headless
    @coveo/headless lint results:
    Warnings:
    1. pkg.exports["."].types types is interpreted as ESM when resolving with the "require" condition. This causes the types to only work when dynamically importing the package, even though the package exports CJS. Consider splitting out two "types" conditions for "import" and "require", and use the .cts extension, e.g. pkg.exports["."].require.types: "./dist/definitions/index.d.cts"
    ```
    alexprudhomme authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    015040f View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    8795d9c View commit details
    Browse the repository at this point in the history
  27. remove script

    alexprudhomme committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    921168c View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    4db6223 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    0715277 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Configuration menu
    Copy the full SHA
    3d0fc63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78f5bda View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    97cbe45 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    44c6ee2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f7858d1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2869bb9 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    b551c24 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a08c38f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cdee62a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fca54e1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    58d9c32 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7a27083 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    d21fb11 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f33c442 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    19a73d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    bc80970 View commit details
    Browse the repository at this point in the history