test(atomic): put noProducts action in search-box page object instead of base-page-object

[alexprudhomme]

https://coveord.atlassian.net/browse/KIT-3577

[github-actions]

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

• Storybook

• Playwright report

Bundle Size

File	Old (kb)	New (kb)	Change (%)
case-assist	239.2	239.2	0
commerce	337.8	337.8	0
search	407.2	407.2	0
insight	392.1	392.1	0
recommendation	250	250	0
ssr	401.3	401.3	0
ssr-commerce	350	350	0

SSR Progress

Use case	SSR (#)	CSR (#)	Progress (%)
search	39	44	89
recommendation	0	4	0
case-assist	0	6	0
insight	0	27	0
commerce	0	15	0

Detailed logs

search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

[fbeaudoincoveo]

Why, though?

I don't immediately see the benefit of this change, and the Jira doesn't clarify things for me either 😅

Can you explain what motivates this PR?

[alexprudhomme]

Why, though?

I don't immediately see the benefit of this change, and the Jira doesn't clarify things for me either 😅

Can you explain what motivates this PR?

Base-page-object is used in in both search and commerce use case. The noProduct call is something specific to commerce. This is just an OOP improvement. The base class should not include methods that are not applicable to all subclasses.

[fbeaudoincoveo]

Why, though?
I don't immediately see the benefit of this change, and the Jira doesn't clarify things for me either 😅
Can you explain what motivates this PR?

Base-page-object is used in in both search and commerce use case. The noProduct call is something specific to commerce. This is just an OOP improvement. The base class should not include methods that are not applicable to all subclasses.

It doesn't really make sense to have this in the commerce search box page object, though. It's possible to have no products without having a search box. We could have a base commerce page object that extends the base page object... but maybe that's a bit overkill.

I would personally tend to leave things as they were 😁

[fbeaudoincoveo]

I would close this PR. I'm not convinced the proposed change is an improvement.