Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headless): add define functions for RecentQueriesList, FieldSuggestionsGenerator, Triggers in commerce SSR #4258

Merged
merged 10 commits into from
Aug 9, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Aug 6, 2024

no samples for FieldSuggestionsGenerator as it is a flag enabled feature.

https://coveord.atlassian.net/browse/KIT-3450

@alexprudhomme alexprudhomme changed the base branch from master to KIT-3449 August 6, 2024 17:01
@alexprudhomme alexprudhomme changed the title feat(headless): add define functions for RecentQueriesList, InstantProducts, Sort, FieldSuggestionsGenerator, Triggers in commerce SSR feat(headless): add define functions for RecentQueriesList, InstantProducts, FieldSuggestionsGenerator, Triggers in commerce SSR Aug 6, 2024
Copy link

github-actions bot commented Aug 7, 2024

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.1 244.1 0
commerce 341.2 341.2 0
search 414 414 0
insight 391.7 391.7 0
product-listing 306.4 306.4 0
product-recommendation 210.4 210.4 0
recommendation 257.2 257.2 0
ssr 405 405 0
ssr-commerce 344.9 351.8 2

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme changed the title feat(headless): add define functions for RecentQueriesList, InstantProducts, FieldSuggestionsGenerator, Triggers in commerce SSR feat(headless): add define functions for RecentQueriesList, FieldSuggestionsGenerator, Triggers in commerce SSR Aug 7, 2024
@alexprudhomme alexprudhomme marked this pull request as ready for review August 7, 2024 12:29
@alexprudhomme alexprudhomme requested review from a team as code owners August 7, 2024 12:29
@alexprudhomme alexprudhomme requested review from fpbrault, y-lakhdar and louis-bompart and removed request for a team August 7, 2024 12:29
@alexprudhomme alexprudhomme merged commit 0848796 into KIT-3449 Aug 9, 2024
2 checks passed
@alexprudhomme alexprudhomme deleted the KIT-3450 branch August 9, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants