-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(refine-modal): include facets from atomic-external #4219
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
42ccc5b
to
668bdcf
Compare
packages/atomic/src/components/common/facets/facet-header/facet-header.tsx
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-refine-toggle/atomic-refine-toggle.new.stories.tsx
Show resolved
Hide resolved
packages/atomic/src/components/common/facets/facet-header/facet-header.tsx
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-refine-toggle/atomic-refine-toggle.new.stories.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I tested with the facet-manager and also with automatic facets. Two things :
1-The facets in the facet manager seem to be in random order.
< atomic-layout-section section="facets">
<atomic-facet field="author" label="facet1"></atomic-facet>
<atomic-facet-manager>
<atomic-facet field="author" label="facet10"></atomic-facet>
<atomic-facet field="author" label="facet11"></atomic-facet>
<atomic-facet field="author" label="facet12"></atomic-facet>
</atomic-facet-manager>
</atomic-layout-section>
2-The automatic facets are being put at the bottom.
<atomic-layout-section section="facets">
<atomic-facet field="author" label="facet1"></atomic-facet>
<atomic-automatic-facet-generator
desired-count="3"
></atomic-automatic-facet-generator>
</atomic-layout-section>
This sorting stuff is so annoying 😢
packages/atomic/src/components/search/atomic-external/atomic-external.tsx
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-external/atomic-external.tsx
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-refine-toggle/atomic-refine-toggle.new.stories.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/facets/facet-header/facet-header.tsx
Show resolved
Hide resolved
packages/atomic/src/components/search/atomic-refine-toggle/e2e/atomic-refine-toggle.e2e.ts
Show resolved
Hide resolved
…mic-refine-toggle.new.stories.tsx Co-authored-by: Alex Prudhomme <[email protected]>
Consider all atomic-search-interface & atomic-external for the facet acquisitions of the refine-modal. Rough algo - If a facet is not in a section, put it in the 'orphan bucket' - Sort facet by interface - In a same interface, put vertical facet first, horizontal facet second - Once all non-orphaned facets are sorted out, sort the orphan facets in DOM order, and add'em. KIT-3428 --------- Co-authored-by: Alex Prudhomme <[email protected]>
Consider all atomic-search-interface & atomic-external for the facet acquisitions of the refine-modal.
Rough algo
KIT-3428