Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(headless): add tab manager controller #4195

Merged
merged 5 commits into from
Jul 23, 2024
Merged

feat(headless): add tab manager controller #4195

merged 5 commits into from
Jul 23, 2024

Conversation

fpbrault
Copy link
Contributor

@fpbrault fpbrault commented Jul 17, 2024

This PR adds the tab manager controller, which will be used for the atomic-tab-manager component.

https://coveord.atlassian.net/browse/CDX-1582

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jul 17, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 245.1 245.1 0
commerce 341.6 341.6 0
search 413.6 414 0.1
insight 392.3 392.4 0
product-listing 307.1 307.1 0
product-recommendation 211.4 211.4 0
recommendation 258.2 258.2 0
ssr 404.9 405.4 0.1

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, nitpik maybe refactor and use/create an action for this 'prep up query without filters'

@fpbrault fpbrault added this pull request to the merge queue Jul 23, 2024
Merged via the queue into master with commit 0eddd7f Jul 23, 2024
109 of 116 checks passed
@fpbrault fpbrault deleted the CDX-1582 branch July 23, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants