fix(headless commerce): correctly determine hasBreadcrumbs value for category facets

packages/headless/src/controllers/commerce/core/breadcrumb-manager/headless-core-breadcrumb-manager.test.ts

@@ -35,7 +35,10 @@ import {
   buildMockCommerceNumericFacetResponse,
   buildMockCommerceRegularFacetResponse,
 } from '../../../../test/mock-commerce-facet-response';
-import {buildMockCommerceRegularFacetValue} from '../../../../test/mock-commerce-facet-value';
+import {
+  buildMockCategoryFacetValue,
+  buildMockCommerceRegularFacetValue,
+} from '../../../../test/mock-commerce-facet-value';
 import {buildMockCommerceState} from '../../../../test/mock-commerce-state';
 import {
   buildMockCommerceEngine,
@@ -121,7 +124,7 @@ describe('core breadcrumb manager', () => {
       expect(breadcrumbManager.state.hasBreadcrumbs).toEqual(false);
     });
 
-    it('#hasBreadcrumbs is false when all facet values are idle', () => {
+    it('#hasBreadcrumbs is false when all values in a non-category facet are idle', () => {
       setFacetsState(
         buildMockCommerceRegularFacetResponse({
           facetId,
@@ -132,7 +135,18 @@ describe('core breadcrumb manager', () => {
       expect(breadcrumbManager.state.hasBreadcrumbs).toEqual(false);
     });
 
-    it('#hasBreadcrumbs is true when there is a selected facet value', () => {
+    it('#hasBreadcrumb is false when all values in a category facet are idle', () => {
+      setFacetsState(
+        buildMockCategoryFacetResponse({
+          facetId: 'category_facet',
+          values: [buildMockCategoryFacetValue({state: 'idle'})],
+        })
+      );
+
+      expect(breadcrumbManager.state.hasBreadcrumbs).toEqual(false);
+    });
+
+    it('#hasBreadcrumbs is true when there is a selected value in a non-category facet', () => {
       setFacetsState(
         buildMockCommerceRegularFacetResponse({
           facetId,
@@ -143,6 +157,37 @@ describe('core breadcrumb manager', () => {
       expect(breadcrumbManager.state.hasBreadcrumbs).toEqual(true);
     });
 
+    it('#hasBreadcrumbs is true when the top parent value is selected in a category facet', () => {
+      setFacetsState(
+        buildMockCategoryFacetResponse({
+          facetId: 'category_facet',
+          values: [buildMockCategoryFacetValue({state: 'selected'})],
+        })
+      );
+
+      expect(breadcrumbManager.state.hasBreadcrumbs).toEqual(true);
+    });
+
+    it('#hasBreadcrumbs is true when a child value is selected in a category facet', () => {
+      setFacetsState(
+        buildMockCategoryFacetResponse({
+          facetId: 'category_facet',
+          values: [
+            buildMockCategoryFacetValue({
+              state: 'idle',
+              children: [
+                buildMockCategoryFacetValue({
+                  state: 'selected',
+                }),
+              ],
+            }),
+          ],
+        })
+      );
+
+      expect(breadcrumbManager.state.hasBreadcrumbs).toEqual(true);
+    });
+
     it('#hasBreadcrumbs is true when there is an excluded facet value', () => {
       setFacetsState(
         buildMockCommerceRegularFacetResponse({

packages/headless/src/controllers/commerce/core/breadcrumb-manager/headless-core-breadcrumb-manager.ts

@@ -238,11 +238,13 @@ export function buildCoreBreadcrumbManager(
           .map((facetId) =>
             options.facetResponseSelector(engine[stateKey], facetId)
           )
-          .filter(
-            (facet): facet is AnyFacetResponse =>
-              facet !== undefined &&
-              facet.values.length > 0 &&
-              facet.values.some((value) => value.state !== 'idle')
+          .filter((facet): facet is AnyFacetResponse =>
+            facet !== undefined &&
+            facet.values.length > 0 &&
+            facet.type !== 'hierarchical'
+              ? facet.values.some((value) => value.state !== 'idle')
+              : findActiveValueAncestry((facet as CategoryFacetResponse).values)
+                  .length > 0
           )
           .map(createBreadcrumb) ?? [];