chore(atomic): fix build on windows #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
louis-bompart
changed the title
|
@lvu285 can you validate that all's well on your side? |
mrrajamanickam-coveo
approved these changes
Aug 24, 2023
dmbrooke
approved these changes
Aug 24, 2023
btaillon-coveo
approved these changes
Aug 24, 2023
Agreed, I had planned to raised up the issue and discuss it with tailwind gang today. |
louis-bompart
force-pushed
the
KIT-2691
branch
from
a9b178a
to
5aa8b08
Compare
|
@louis-bompart confirmed it fix the issue on my Windows. Thanks! |
lvu285
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empirical fix, I didn't trace back exactly where it goes haywire.
because lower limits for opened files.
Gut feeling: too much parallelism made using fs.promises, which in turn leads to Windows to
Solution: Reuse the synchronous code on Windows, and let Linux be Linux.
I prefer to not invest more, will prolly be fixed when Oxide (Tailwind not-so-secret Rust sauce that should come 🔜 ™️) will land.
https://coveord.atlassian.net/browse/KIT-2691