feat(headless): support facet exclusion in search parameter manager #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
olamothe
approved these changes
Aug 22, 2023
...less/src/controllers/core/search-parameter-manager/headless-core-search-parameter-manager.ts
Outdated
Show resolved
Hide resolved
packages/headless/src/features/search-parameters/search-parameter-serializer.ts
Outdated
Show resolved
Hide resolved
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
y-lakhdar
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-2684
Realized part-way through implementing facet exclusion for the core atomic facet that we weren't supporting excluding facet values in the search parameter manager. Therefore, I added support for this with a new parameter labelled
fExcluded.