feat(atomic): empty no-result-text prop hides component when no child results found #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
...s/insight/result-templates/atomic-insight-result-children/atomic-insight-result-children.tsx
Outdated
Show resolved
Hide resolved
...s/insight/result-templates/atomic-insight-result-children/atomic-insight-result-children.tsx
Outdated
Show resolved
Hide resolved
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
nathanlb
changed the title
dmbrooke
approved these changes
Jul 19, 2023
packages/atomic/src/components/common/result-children/result-children-common.tsx
Show resolved
Hide resolved
drosenfeld-coveo
approved these changes
Jul 21, 2023
nathanlb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when there are no result children in a template that supports them we display a message.
For the builder use-case we use a dynamic templating engine that requires us to support folded results without knowing if they'll ever exist. So we need a way to completely hide the child results section when there are none to be shown.
This justification based solely on the very niche builder use case probably isn't super convincing but I can see regular users also preferring to show nothing rather than a label saying there is nothing.
Also reduced the excessive spacing around the folded results due to result-action changes.