feat(smart-snippet): allow link _target modifs #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguerinCoveo
requested review from
olamothe,
louis-bompart,
dmbrooke,
nathanlb and
pathiery
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. Bundle Size
|
dguerinCoveo
force-pushed
the
feat/SVCINT-2386-smart-snippet-new-tab
branch
3 times, most recently
from
3c0fbde
to
9f00fc5
Compare
dguerinCoveo
commented
Jul 13, 2023
packages/atomic/src/components/common/result-link/attributes-slot.ts
Outdated
Show resolved
Hide resolved
.../common/smart-snippets/atomic-smart-snippet-suggestions/smart-snippet-suggestions-common.tsx
Outdated
Show resolved
Hide resolved
packages/atomic/src/components/common/result-link/attributes-slot.ts
Outdated
Show resolved
Hide resolved
dguerinCoveo
force-pushed
the
feat/SVCINT-2386-smart-snippet-new-tab
branch
2 times, most recently
from
ce11cec
to
748824d
Compare
dguerinCoveo
force-pushed
the
feat/SVCINT-2386-smart-snippet-new-tab
branch
from
75611bd
to
c54491e
Compare
louis-bompart
approved these changes
Jul 24, 2023
.../search/smart-snippets/atomic-smart-snippet-suggestions/atomic-smart-snippet-suggestions.tsx
Outdated
Show resolved
Hide resolved
...es/atomic/src/components/search/smart-snippets/atomic-smart-snippet/atomic-smart-snippet.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Benjamin Taillon <[email protected]>
dguerinCoveo
force-pushed
the
feat/SVCINT-2386-smart-snippet-new-tab
branch
from
27cdb45
to
347af90
Compare
dguerinCoveo
commented
Jul 24, 2023
.../search/smart-snippets/atomic-smart-snippet-suggestions/atomic-smart-snippet-suggestions.tsx
Show resolved
Hide resolved
mikegron
approved these changes
Jul 24, 2023
|
@nathanlb should I update the atomic-insight-smart-snippet* component as well while I'm there? |
pathiery
approved these changes
Jul 25, 2023
btaillon-coveo
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/SVCINT-2386
Allows the modification of the _target attribute in the
<a>tags inside smart snippets and smart snippets suggestions. Uses the same mechanism as result links.Demo:
https://github.com/coveo/ui-kit/assets/64476861/0e4b9c31-cc7a-4048-908e-3d3f88f385fa