forgot to push this commit

coveo · Aug 14, 2024 · acd71fb · acd71fb
1 parent c004b57
commit acd71fb
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 30 deletions.
diff --git a/packages/quantic/cypress/e2e/default-1/refine-modal-content/refine-modal-content.cypress.ts b/packages/quantic/cypress/e2e/default-1/refine-modal-content/refine-modal-content.cypress.ts
@@ -144,7 +144,7 @@ describe('quantic-refine-content', () => {
 
   describe('when using custom sort options', () => {
     it('should render the same custom sort options in the sort component and in the refine modal', () => {
-      visitRefineContent({});
+      visitRefineContent();
       Expect.sortCriteriaInSearchRequest(defaultCustomOptionValue);
 
       scope(

diff --git a/...quantic/force-app/main/default/lwc/quanticRefineModalContent/quanticRefineModalContent.js b/...quantic/force-app/main/default/lwc/quanticRefineModalContent/quanticRefineModalContent.js
@@ -269,15 +269,7 @@ export default class QuanticRefineModalContent extends LightningElement {
    * @returns {Array<SortOption>}
    */
   get sortOptions() {
-    return this.isSortComponentReady ? this.sortData : [];
-  }
-
-  /**
-   * Whether custom sort options are found in the store.
-   * @returns {boolean}
-   */
-  get hasSortOptions() {
-    return this.sortData.length > 0;
+    return this.sortData.length > 0 ? this.sortData : [];
   }
 
   get shouldDisplayFiltersTitle() {

diff --git a/...e-app/main/default/lwc/quanticRefineModalContent/templates/disabledDynamicNavigation.html b/...e-app/main/default/lwc/quanticRefineModalContent/templates/disabledDynamicNavigation.html
@@ -8,16 +8,14 @@
       <div class="slds-var-m-bottom_small slds-clearfix">
         <template lwc:if={isSortComponentReady}>
           <c-quantic-sort class="slds-float_left" engine-id={engineId}>
-            <template lwc:if={hasSortOptions}>
-              <template for:each={sortOptions} for:item="sortOption">
-                <c-quantic-sort-option
-                  key={sortOption.value}
-                  value={sortOption.value}
-                  criterion={sortOption.criterion}
-                  label={sortOption.label}
-                  slot="sortOption"
-                ></c-quantic-sort-option>
-              </template>
+            <template for:each={sortOptions} for:item="sortOption">
+              <c-quantic-sort-option
+                key={sortOption.value}
+                value={sortOption.value}
+                criterion={sortOption.criterion}
+                label={sortOption.label}
+                slot="sortOption"
+              ></c-quantic-sort-option>
             </template>
           </c-quantic-sort>
         </template>

diff --git a/...tic/force-app/main/default/lwc/quanticRefineModalContent/templates/dynamicNavigation.html b/...tic/force-app/main/default/lwc/quanticRefineModalContent/templates/dynamicNavigation.html
@@ -8,16 +8,14 @@
       <div class="slds-var-m-bottom_small slds-clearfix">
         <template lwc:if={isSortComponentReady}>
           <c-quantic-sort class="slds-float_left" engine-id={engineId}>
-            <template lwc:if={hasSortOptions}>
-              <template for:each={sortOptions} for:item="sortOption">
-                <c-quantic-sort-option
-                  key={sortOption.value}
-                  value={sortOption.value}
-                  criterion={sortOption.criterion}
-                  label={sortOption.label}
-                  slot="sortOption"
-                ></c-quantic-sort-option>
-              </template>
+            <template for:each={sortOptions} for:item="sortOption">
+              <c-quantic-sort-option
+                key={sortOption.value}
+                value={sortOption.value}
+                criterion={sortOption.criterion}
+                label={sortOption.label}
+                slot="sortOption"
+              ></c-quantic-sort-option>
             </template>
           </c-quantic-sort>
         </template>