applied fix for sortOptions initialization

coveo · Aug 13, 2024 · 70cb789 · 70cb789
1 parent f76c3a7
commit 70cb789
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 18 deletions.
diff --git a/packages/quantic/cypress/e2e/default-1/sort/sort-expectations.ts b/packages/quantic/cypress/e2e/default-1/sort/sort-expectations.ts
@@ -1,5 +1,5 @@
 import {Interception} from 'cypress/types/net-stubbing';
-import {InterceptAliases} from '../../../page-objects/search';
+import {getQueryAlias, InterceptAliases} from '../../../page-objects/search';
 import {useCaseEnum} from '../../../page-objects/use-case';
 import {
   completeSearchRequest,
@@ -45,12 +45,7 @@ function sortExpectations(selector: SortSelector) {
       value: string,
       useCase: useCaseEnum
     ) => {
-      const interceptAliasToUse =
-        useCase === useCaseEnum.search
-          ? InterceptAliases.Search
-          : InterceptAliases.Insight;
-
-      cy.get<Interception>(interceptAliasToUse)
+      cy.get<Interception>(getQueryAlias(useCase))
         .then((interception) => {
           const body = interception.request.body;
           expect(body.sortCriteria).to.equal(value);

diff --git a/...quantic/force-app/main/default/lwc/quanticRefineModalContent/quanticRefineModalContent.js b/...quantic/force-app/main/default/lwc/quanticRefineModalContent/quanticRefineModalContent.js
@@ -75,6 +75,8 @@ export default class QuanticRefineModalContent extends LightningElement {
 
   /** @type {object} */
   facetData;
+  /** @type {boolean} */
+  isSortComponentReady;
   /** @type {object} */
   sortData;
   /** @type {boolean} */
@@ -136,6 +138,7 @@ export default class QuanticRefineModalContent extends LightningElement {
    */
   getSortOptionsFromStore() {
     this.sortData = getAllSortOptionsFromStore(this.engineId);
+    this.isSortComponentReady = true;
   }
 
   /**
@@ -266,7 +269,7 @@ export default class QuanticRefineModalContent extends LightningElement {
    * @returns {Array<SortOption>}
    */
   get sortOptions() {
-    return this.hasSortOptions ? this.sortData : [];
+    return this.isSortComponentReady ? this.sortData : [];
   }
 
   get shouldDisplayFiltersTitle() {
@@ -294,14 +297,6 @@ export default class QuanticRefineModalContent extends LightningElement {
     return this.facetData && !!Object.keys(this.facetData).length;
   }
 
-  /**
-   * Indicates whether the sort options are available.
-   * @returns {boolean}
-   */
-  get hasSortOptions() {
-    return this.sortData?.length > 0;
-  }
-
   /**
    * @param {CustomEvent} event
    */

diff --git a/...e-app/main/default/lwc/quanticRefineModalContent/templates/disabledDynamicNavigation.html b/...e-app/main/default/lwc/quanticRefineModalContent/templates/disabledDynamicNavigation.html
@@ -6,7 +6,7 @@
   <template lwc:else>
     <template if:false={hideSort}>
       <div class="slds-var-m-bottom_small slds-clearfix">
-        <template lwc:if={hasSortOptions}>
+        <template lwc:if={isSortComponentReady}>
           <c-quantic-sort class="slds-float_left" engine-id={engineId}>
             <template for:each={sortOptions} for:item="sortOption">
               <c-quantic-sort-option

diff --git a/...tic/force-app/main/default/lwc/quanticRefineModalContent/templates/dynamicNavigation.html b/...tic/force-app/main/default/lwc/quanticRefineModalContent/templates/dynamicNavigation.html
@@ -6,7 +6,7 @@
   <template lwc:else>
     <template if:false={hideSort}>
       <div class="slds-var-m-bottom_small slds-clearfix">
-        <template lwc:if={hasSortOptions}>
+        <template lwc:if={isSortComponentReady}>
           <c-quantic-sort class="slds-float_left" engine-id={engineId}>
             <template for:each={sortOptions} for:item="sortOption">
               <c-quantic-sort-option