Add missing UTs

https://coveord.atlassian.net/browse/KIT-2684
coveo · Aug 22, 2023 · 56c894f · 56c894f
1 parent 4f88e95
commit 56c894f
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/.../controllers/core/search-parameter-manager/headless-core-search-parameter-manager.test.ts b/.../controllers/core/search-parameter-manager/headless-core-search-parameter-manager.test.ts
@@ -118,6 +118,34 @@ describe('search parameter manager', () => {
     });
   });
 
+  describe('#state.parameters.fExcluded', () => {
+    it('only includes excluded values when a facet has some', () => {
+      const excluded = buildMockFacetValueRequest({
+        value: 'a',
+        state: 'excluded',
+      });
+      const idle = buildMockFacetValueRequest({value: 'b', state: 'idle'});
+      const selected = buildMockFacetValueRequest({
+        value: 'c',
+        state: 'selected',
+      });
+
+      const currentValues = [excluded, idle, selected];
+      engine.state.facetSet = {
+        author: buildMockFacetSlice({
+          request: buildMockFacetRequest({currentValues}),
+        }),
+      };
+
+      expect(manager.state.parameters.fExcluded).toEqual({author: ['a']});
+    });
+
+    it('is not included when there are no facets with selected values', () => {
+      engine.state.facetSet = {author: buildMockFacetSlice()};
+      expect(manager.state.parameters).not.toContain('fExcluded');
+    });
+  });
+
   describe('#state.parameters.cf', () => {
     it('only includes selected values when a category facet has some', () => {
       const selected = buildMockCategoryFacetValueRequest({
@@ -309,7 +337,6 @@ describe('search parameter manager', () => {
     });
     engine.state.automaticFacetSet.set = {a: slice};
 
-
     engine.state.query.q = 'a';
     engine.state.sortCriteria = 'qre';
 

diff --git a/packages/headless/src/features/search-parameters/search-parameter-analytics-actions.test.ts b/packages/headless/src/features/search-parameters/search-parameter-analytics-actions.test.ts
@@ -103,14 +103,14 @@ function testFacetExcludeLogging(
     action2: SearchAction
   ) => void
 ) {
-  /*testFacetLogging('fExcluded', expectIdenticalActionType);
+  testFacetLogging('fExcluded', expectIdenticalActionType);
 
   it('should log #logFacetSelect when an fExcluded parameter is added', () => {
     expectIdenticalActionType(
       logParametersChange({}, {fExcluded: {author: ['Cervantes']}}),
       logFacetExclude({facetId: 'author', facetValue: 'Cervantes'})
     );
-  });*/
+  });
 
   it('should log #logFacetSelect when an fExcluded parameter is modified & a value added', () => {
     expectIdenticalActionType(