Skip to content

Commit

Permalink
feat(genqa): update citations (#4243)
Browse files Browse the repository at this point in the history
  • Loading branch information
jelmedini authored Aug 9, 2024
1 parent 7f04f73 commit 54948d8
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 16 deletions.
2 changes: 0 additions & 2 deletions packages/atomic/cypress/e2e/generated-answer-selectors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ export const GeneratedAnswerSelectors = {
GeneratedAnswerSelectors.shadow().find('[part="citations-label"]'),
citationTitle: () =>
GeneratedAnswerSelectors.citation().find('.citation-title'),
citationIndex: () =>
GeneratedAnswerSelectors.citation().find('[part="citation-index"]'),
citationCard: () =>
GeneratedAnswerSelectors.shadow().find('[part="citation-popover"]'),
loader: () => GeneratedAnswerSelectors.shadow().find('.typing-indicator'),
Expand Down
1 change: 0 additions & 1 deletion packages/atomic/cypress/e2e/generated-answer.cypress.ts
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,6 @@ describe('Generated Answer Test Suites', () => {
'have.text',
testCitation.title
);
GeneratedAnswerSelectors.citationIndex().should('have.text', '1');
GeneratedAnswerSelectors.citation().should(
'have.attr',
'href',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@
height: var(--height);
}

[part='citation-index'] {
height: var(--index-height);
width: var(--index-height);
}

[part='citation-popover'] {
--popover-width: 350px;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -158,12 +158,6 @@ export class AtomicCitation {
onFocus={this.openPopover}
onBlur={this.closePopover}
>
<div
part="citation-index"
class="text-bg-primary flex shrink-0 items-center rounded-full font-medium"
>
<div class="mx-auto">{this.index + 1}</div>
</div>
<span class="citation-title mx-1 truncate">
{this.citation.title}
</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ import {InsightBindings} from '../atomic-insight-interface/atomic-insight-interf
*
* @part citation - The link that allows the user to navigate to the item.
* @part citation-popover - The pop-up that shows an item preview when the user hovers over the citation.
* @part citation-index - The content of the citation item.
*/
@Component({
tag: 'atomic-insight-generated-answer',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ import {Bindings} from '../atomic-search-interface/atomic-search-interface';
*
* @part citation - The link that allows the user to navigate to the item.
* @part citation-popover - The pop-up that shows an item preview when the user hovers over the citation.
* @part citation-index - The content of the citation item.
*/
@Component({
tag: 'atomic-generated-answer',
Expand Down

0 comments on commit 54948d8

Please sign in to comment.