fix(atomic): atomic-product layout in grid mode consistent on all screen sizes #24256
Annotations
2 errors, 2 warnings, and 1 notice
Run /./.github/actions/playwright-atomic:
packages/atomic/src/components/commerce/product-template-components/atomic-product-description/e2e/page-object.ts#L29
1) [chromium] › components/commerce/product-template-components/atomic-product-description/e2e/atomic-product-description.e2e.ts:149:13 › atomic-product-description › when description is truncated › when truncateAfter is set to 4 › when clicking the "Show More" button › when isCollapsible is false › should expand description
TypeError: Cannot read properties of undefined (reading '0')
at components/commerce/product-template-components/atomic-product-description/e2e/page-object.ts:29
27 | const response = await route.fetch();
28 | const body = await response.json();
> 29 | body.products[0].ec_description =
| ^
30 | 'This is a long description that should be truncated'.repeat(10);
31 | await route.fulfill({
32 | response,
at /home/runner/work/ui-kit/ui-kit/packages/atomic/src/components/commerce/product-template-components/atomic-product-description/e2e/page-object.ts:29:20
|
Run /./.github/actions/playwright-atomic:
packages/atomic/src/components/commerce/product-template-components/atomic-product-description/e2e/atomic-product-description.e2e.ts#L145
1) [chromium] › components/commerce/product-template-components/atomic-product-description/e2e/atomic-product-description.e2e.ts:149:13 › atomic-product-description › when description is truncated › when truncateAfter is set to 4 › when clicking the "Show More" button › when isCollapsible is false › should expand description
Error: locator.waitFor: Test ended.
Call log:
- waiting for locator('atomic-product-description[class*="hydrated"]').first() to be visible
143 | args: {truncateAfter: value, isCollapsible: false},
144 | });
> 145 | await productDescription.hydrated.first().waitFor();
| ^
146 | await productDescription.showMoreButton.first().click();
147 | });
148 |
at /home/runner/work/ui-kit/ui-kit/packages/atomic/src/components/commerce/product-template-components/atomic-product-description/e2e/atomic-product-description.e2e.ts:145:57
|
Run /./.github/actions/playwright-atomic:
packages/atomic/[chromium] › components/commerce/product-template-components/atomic-product-excerpt/e2e/atomic-product-excerpt.e2e.ts#L1
packages/atomic/[chromium] › components/commerce/product-template-components/atomic-product-excerpt/e2e/atomic-product-excerpt.e2e.ts took 44.7s
|
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "result-lists-screenshots", "ssr-pages-prd-screenshots".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Run /./.github/actions/playwright-atomic
1 flaky
[chromium] › components/commerce/product-template-components/atomic-product-description/e2e/atomic-product-description.e2e.ts:149:13 › atomic-product-description › when description is truncated › when truncateAfter is set to 4 › when clicking the "Show More" button › when isCollapsible is false › should expand description
24 passed (60.0s)
|
Loading