Two small fixes found by static analysis

couchbaselabs · Oct 12, 2023 · 3431c37 · 3431c37
1 parent 59109c7
commit 3431c37
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/include/PubSub.hh b/include/PubSub.hh
@@ -198,7 +198,7 @@ namespace crouton::ps {
     /// ```
     template <typename P, typename S, typename PP = std::remove_reference_t<P>, typename SS = std::remove_reference_t<S>>  requires(std::is_same_v<pub_type<PP>,sub_type<SS>>)
     [[nodiscard]] S operator| (P&& pub, S&& sub) {
-        auto sharedP = std::make_shared<PP>(std::move(pub));
+        auto sharedP = std::make_shared<PP>(std::forward<P>(pub));
         sub.subscribeTo(std::move(sharedP));
         return sub;
     }

diff --git a/include/io/HTTPParser.hh b/include/io/HTTPParser.hh
@@ -160,7 +160,7 @@ namespace crouton::io::http {
         ASYNC<string> entireBody();
 
         /// After a call to parseData, returns body bytes that were read by the call.
-        string latestBodyData()    {return std::move(_body);}
+        string latestBodyData()    {string b(std::move(_body)); _body.clear(); return b;}
 
     private:
         Parser(IStream*, Role role);