Skip to content

Commit

Permalink
CCBC-1583: disable collections support if KV does not ack it
Browse files Browse the repository at this point in the history
Change-Id: Ia06be48c535529b3a4ebe7493a1f2b7b475a6763
Reviewed-on: https://review.couchbase.org/c/libcouchbase/+/185135
Tested-by: Build Bot <[email protected]>
Reviewed-by: David Kelly <[email protected]>
  • Loading branch information
avsej committed Jan 20, 2023
1 parent 13ef206 commit 39e6ab8
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/mcserver/mcserver.cc
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,11 @@ void Server::handle_connected(lcbio_SOCKET *sock, lcb_STATUS err, lcbio_OSERR sy
connreq = SessionRequest::start(sock, settings, settings->config_node_timeout, on_connected, this);
return;
} else {
if (settings->use_collections && !sessinfo->has_feature(PROTOCOL_BINARY_FEATURE_COLLECTIONS)) {
settings->use_collections = 0;
lcb_log(LOGARGS_T(DEBUG), "<%s:%s> (SRV=%p) Disable collections support as not every node support it",
curhost->host, curhost->port, (void *)this);
}
jsonsupport = sessinfo->has_feature(PROTOCOL_BINARY_FEATURE_JSON);
compsupport = sessinfo->has_feature(PROTOCOL_BINARY_FEATURE_SNAPPY);
mutation_tokens = sessinfo->has_feature(PROTOCOL_BINARY_FEATURE_MUTATION_SEQNO);
Expand Down

0 comments on commit 39e6ab8

Please sign in to comment.