CBL-6066: Implement Database Full-Sync Option #3317
Merged
+194
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
velicuvlad
commented
Aug 1, 2024
velicuvlad
commented
- Implemented FullSync DatabaseConfiguration property.
- Only Obj-C tests do check for c4db_config2 kC4DB_DiskSyncFull flag
- Updated LiteCore to 3.1.9-5
pasin
requested changes
Aug 1, 2024
Objective-C/CBLDatabase.mm
Outdated
| @@ -1150,4 +1152,10 @@ + (void) checkFileLogging: (BOOL)swift { | |||
| }); | |||
| } | |||
|
|
|||
| #pragma mark - Private for test | |||
|
|
|||
| - (C4DatabaseConfig2) getC4DBConfig2: (CBLDatabaseConfiguration*) config { | |||
There was a problem hiding this comment.
This function signature should be
(C4DatabaseConfig2) getC4DBConfig;
``
Then it should return C4DatabaseConfig2 from c4db. Otherwise it doesn't check that effective config in LiteCore c4db.
pasin
approved these changes
Aug 1, 2024
velicuvlad
added a commit
that referenced
this pull request
Aug 1, 2024
- Implemented FullSync DatabaseConfiguration property. - Only Obj-C tests do check for c4db_config2 kC4DB_DiskSyncFull flag
velicuvlad
added a commit
that referenced
this pull request
Aug 2, 2024
- Implemented FullSync DatabaseConfiguration property. - Only Obj-C tests do check for c4db_config2 kC4DB_DiskSyncFull flag
velicuvlad
added a commit
that referenced
this pull request
Aug 5, 2024
* LiteCore 3.2.0-223 * cherry picked 5c10248 from release/3.1 branch. A couple of small, easy-to-resolve conflicts - nothing important. CBL-6066: Implement Database Full-Sync Option (#3317) - Implemented FullSync DatabaseConfiguration property. - Only Obj-C tests do check for c4db_config2 kC4DB_DiskSyncFull flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.