CBL-5035 : Fix missing pending conflict array initialization. #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix bad bug from mistakenly deleting the code after cleaning up debug logic. * Added additional check to ensure that there are no more conflicts scheduled after the replicator is stopped. I don’t think it would happen as LiteCore will not be stopped event before sending the doc ended notification but to be sure.
bmeike
reviewed
Nov 11, 2023
| @@ -104,6 +104,7 @@ - (instancetype) initWithConfig: (CBLReplicatorConfiguration *)config { | |||
| _progressLevel = kCBLProgressLevelOverall; | |||
| _changeNotifier = [CBLChangeNotifier new]; | |||
| _docReplicationNotifier = [CBLChangeNotifier new]; | |||
| _pendingConflicts = [NSMutableArray array]; | |||
|
I did not get it either... how was the test passing? |
|
The tests failed on Jenkins. |
velicuvlad
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bad bug of missing the array initialization.
Added additional check to ensure that there are no more conflicts scheduled after the replicator is stopped. This is not expected to happen as LiteCore will not be stopped event before sending the doc ended notification but to be sure.