CBL-2766: Deprecate SortOrder (with QuerySortOrder) #3185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasin
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Not sure what the intention of this PR. This PR removes the SortOrder type but the ticket is deprecating the SortOrder type which has already been done. To remove the SortOrder, we will need to wait for the major release to do it. We are still waiting to see the Beryllium will be the major release or not so we cannot remove the SortOrder as of now.
|
Yes, indeed. I thought we are already expecting Beryllium to be the next major. Will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.