-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBL-2862: Add package validation actions #3173
Conversation
0aa7dae
to
6ac81a1
Compare
@@ -0,0 +1,3 @@ | |||
struct CouchbaseLiteSwift { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couchbase Lite Swift package is a binary swift package. Can you explain why we need this file? If we really need it, can we make it an empty struct without the "Hello, World!"?
.github/workflows/check_package.yml
Outdated
- name: Build & test MacOS | ||
run: | | ||
swift build -v | ||
swift test -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know how this works when trying to build the binary swift package which is generated from swift version 5.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm ... we are doing something similar here but it works.
https://github.com/couchbase/couchbase-lite-swift-ee/blob/master/.github/workflows/swift.yml
7de0d68
to
422ab9d
Compare
No description provided.