CBL-2862: Add package validation actions #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velicuvlad
force-pushed
the
package-valid-test2
branch
from
0aa7dae
to
6ac81a1
Compare
pasin
reviewed
Jun 30, 2023
| @@ -0,0 +1,3 @@ | |||
| struct CouchbaseLiteSwift { | |||
There was a problem hiding this comment.
Couchbase Lite Swift package is a binary swift package. Can you explain why we need this file? If we really need it, can we make it an empty struct without the "Hello, World!"?
.github/workflows/check_package.yml
Outdated
| - name: Build & test MacOS | ||
| run: | | ||
| swift build -v | ||
| swift test -v |
There was a problem hiding this comment.
I do not know how this works when trying to build the binary swift package which is generated from swift version 5.3.
There was a problem hiding this comment.
Umm ... we are doing something similar here but it works.
https://github.com/couchbase/couchbase-lite-swift-ee/blob/master/.github/workflows/swift.yml
velicuvlad
force-pushed
the
package-valid-test2
branch
from
7de0d68
to
422ab9d
Compare
borrrden
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.